FIX Always include unsaved anchors from the current WYSIWYG field #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Just small request, could you update this test if it's needed |
GuySartorelli
force-pushed
the
pulls/4/get-unsaved-anchors-in-current-field
branch
from
5f7d0aa
to
ead1d2f
Compare
|
I don't think it's feasible to test this via jest - instead I have added two new behat tests. |
sabina-talipova
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2741
In that PR, I accidentally caused a regression where an anchor which has not yet been saved would not be available to link from the same field.
This PR resolves that regression, while still fetching any additional anchors from the server for the current page (i.e. from other fields or DataObjects which have been saved).
Parent issue