DEP Update JS dependencies #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
GuySartorelli
force-pushed
the
pulls/2/update-js-1725204113
branch
from
76b9896
to
f8433cf
Compare
Comment on lines
-17
to
-20
| // fix firefox fieldset width behaviour http://stackoverflow.com/a/17863685 | ||
| @-moz-document url-prefix() { | ||
| display: table-cell; | ||
| } |
There was a problem hiding this comment.
Had to manually fix this linting problem https://github.com/silverstripe/silverstripe-admin/actions/runs/10655206581/job/29538023643
client/src/styles/legacy/_forms.scss
18:3 ✖ Unexpected vendor-prefixed at-rule "@-moz-document" at-rule-no-vendor-prefix
As per the edit to the linked stackoverflow answer:
The Firefox bug described below is fixed as of Firefox 53
emteknetnz
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated yarn upgrade and yarn build
This pull-request was created by a GitHub Action and for GitHubs own security reasons cannot automatically trigger a subsequent CI workflow like it would if a human created the pull-request.
Instead a CI workflow was created via the GitHub API. One shortcoming of doing this is the results of the CI workflow do not show above the merge button like they do on normal pull-requests.
BEFORE MERGING - View the CI workflow runs for the branch in this pull-request in this filtered list.