Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Update JS dependencies and update TinyMCE_sslink.js onunmatch() #1558

Merged
merged 1 commit into from
Aug 28, 2023
Merged

DEP Update JS dependencies and update TinyMCE_sslink.js onunmatch() #1558

merged 1 commit into from
Aug 28, 2023

Conversation

emteknetnz
Copy link
Member

This was referenced Aug 24, 2023
Closed
Closed
GuySartorelli
GuySartorelli approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I was concerned that if (root) would always evaluate falsy, but I've dug in and noticed that the ReactRoot property is declared and set in specific sslink implementations (e.g. email link). So this looks fine to me.

@emteknetnz emteknetnz mentioned this pull request Aug 28, 2023
Closed
@GuySartorelli GuySartorelli merged commit 68f3a06 into silverstripe:2 Aug 28, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/update-js branch August 28, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli