Getting Proptypes errors #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time my Android devices show a blank image for the signature page, and do not render any brush strokes. This appears to have been a bug that was fixed in the latest version of signature_pad, so I upgraded the injected Javascript to be 1.5.3. My android and iOS devices both now work with 1.5.3. The changes I made were: 1. Copy/Paste the code from https://github.com/szimek/signature_pad/blob/v1.5.3/signature_pad.js into the 'content' var in signaturePad.js 2. Replace 4 spaces with 2 spaces (following your convention) 3. Replace all // comments with /* */ 4. Copy/Paste the comment at the top of the file
Signatures on Android occasionally fail due to document.body.clientWidth and window.innerWidth (as well as document.body.clientHeight and window.innerHeight) being 0 on initialization. I attempted to fix this by adding a setTimeout with a 300ms delay, but even that was not a 100% effective fix. This issue is most likely related to: http://tripleodeon.com/2011/12/first-understand-your-screen/ http://stackoverflow.com/questions/10610743/android-browsers-screen-width-screen-height-window-innerwidth-window-inner Note that I attempted to apply the ReactNative measured dimensions instead of using document.body.clientWidth, but that broke iOS. This fix will not address any rendering issues related to rotating, since we would need to register a callback and re-initialize the canvas element on rotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proptypes are no longer imported from React they are imported from prop-types library.
So fix this. I did something fix like this
6eaf9cc