[Bug] Plugin leaks memory and crashes Obsidian when initializing large vault repos #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypdick
commented
Jun 26, 2025
| } | ||
| // Process entries sequentially to avoid loading many files in memory at once | ||
| // which can crash Obsidian when initializing a large Obsidian repository. | ||
| for (const entry of entries) { |
Author
There was a problem hiding this comment.
Github is being dumb and making the diff look bigger than it actually is. The only real change is on this line, as well as changing a few return to continue
|
+1 for this PR, works great on my Android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a vault with many files, the plugin extracts every ZIP entry at once. This crashes Obsidian repeatedly on my Pixel 9 Pro. This PR switches the extraction to a simple for loop so that the files are handled one at a time.