Touch up Feedback & Support options and dialog/drawer #2025
Conversation
github-actions
bot
added
the
💻 FW Lite
📝 WalkthroughWalkthroughUpdates feedback/support wording and icons, reorders sidebar items, refactors TroubleshootDialog to use ResponsiveDialog, enhances ResponsiveDialog with prop forwarding and type, adds drawer max-height and optional back-handler disabling, and refreshes translations across multiple locales to match new feedback/support texts. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
frontend/viewer/src/home/HomeView.svelte(1 hunks)frontend/viewer/src/lib/about/FeedbackDialog.svelte(2 hunks)frontend/viewer/src/lib/components/responsive-dialog/responsive-dialog.svelte(2 hunks)frontend/viewer/src/lib/components/ui/drawer/drawer-content.svelte(1 hunks)frontend/viewer/src/lib/components/ui/drawer/drawer.svelte(1 hunks)frontend/viewer/src/lib/troubleshoot/TroubleshootDialog.svelte(2 hunks)frontend/viewer/src/locales/en.po(6 hunks)frontend/viewer/src/locales/es.po(6 hunks)frontend/viewer/src/locales/fr.po(6 hunks)frontend/viewer/src/locales/id.po(6 hunks)frontend/viewer/src/locales/ko.po(6 hunks)frontend/viewer/src/locales/ms.po(6 hunks)frontend/viewer/src/locales/sw.po(6 hunks)frontend/viewer/src/project/ProjectSidebar.svelte(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-14T12:50:25.135Z
Learnt from: myieye
PR: sillsdev/languageforge-lexbox#1906
File: frontend/viewer/src/lib/components/ui/dialog-shared/dialog-shared-root.svelte:3-3
Timestamp: 2025-08-14T12:50:25.135Z
Learning: In the dialog-shared-root.svelte component, the module-level `openDialogs` state is intentionally shared across all component instances to coordinate dialog stacking and overlay behavior across the entire application. This enables proper z-index management where newer dialogs appear on top and only the bottom dialog shows its overlay.
Applied to files:
frontend/viewer/src/lib/components/responsive-dialog/responsive-dialog.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build UI / publish-ui
- GitHub Check: Build API / publish-api
- GitHub Check: check-and-lint
- GitHub Check: frontend-component-unit-tests
- GitHub Check: Build FW Lite and run tests
- GitHub Check: frontend
🔇 Additional comments (8)
frontend/viewer/src/lib/components/ui/drawer/drawer.svelte (1)
10-17: Back-handler guard looks solidConditional addToStack cleanly honors the new
disableBackHandlerprop without affecting existing flows. Nice touch.frontend/viewer/src/lib/components/ui/drawer/drawer-content.svelte (1)
24-26: Appreciate the viewport capThe
max-h-[95dvh]constraint keeps mobile drawers usable without hampering existing layout.frontend/viewer/src/locales/en.po (1)
141-143: LGTM! English translations are complete.All new FeedbackDialog-related entries are properly defined with both source text and translations.
Also applies to: 545-547, 667-669, 996-998, 1086-1088
frontend/viewer/src/lib/components/responsive-dialog/responsive-dialog.svelte (2)
43-43: Verify the drawer container styling changes.The class list was changed from
max-w-sm_tooverflow-auto overscroll-contain. This removes the max-width constraint and adds scrolling behavior. Ensure this aligns with the intended UX, especially on larger mobile screens where content might now span the full width.
11-15: No type compatibility issues between Dialog.Root and Drawer.Root props. TypeScript compiles without errors.frontend/viewer/src/lib/about/FeedbackDialog.svelte (2)
17-17: Verify the community forum URLs are final.The PR description mentions wanting to use the
lexbox.org/fw-lite/feature-requestlink before merging, but the code now usescommunity.software.sil.orgURLs. Please confirm this is the intended final destination.Also applies to: 26-26
15-60: LGTM! FeedbackDialog content updates are clear and user-friendly.The updated wording and new "Get support" option improve the user experience by clearly separating support channels from feature requests and bug reports.
frontend/viewer/src/lib/troubleshoot/TroubleshootDialog.svelte (1)
40-86: LGTM! Clean refactor to ResponsiveDialog.The migration from Dialog to ResponsiveDialog is straightforward and preserves all existing functionality. The addition of
disableBackHandleris appropriate for a troubleshooting dialog where you want to control navigation explicitly.
Before:
After:
