Convert to Actions #289
Merged
Convert to Actions #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briskt
requested changes
Mar 18, 2024
README.md
Outdated
|
|
||
| ecs-deploy -c production1 -n doorman-api -i my.private.repo/doorman-api -e CI_TIMESTAMP | ||
| ecs-deploy -c CLUSTERNAME -n SERVICENAME -i my.private.repo.com/frontend_container:latest -e CI_TIMESTAMP |
There was a problem hiding this comment.
If you're using the -e option, you probably shouldn't supply a tag (e.g. latest).
| so that each task definition refers to a unique docker image/tag. This gives us the | ||
| ability to revert/rollback changes by just selecting a previous task definition and | ||
| updating the service. We plan to add a revert command/option to ecs-deploy to simplify this further. | ||
| For example, we want to use a unique docker image/tag for each task definition. This |
briskt
approved these changes
Mar 18, 2024
forevermatt
reviewed
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed (non-breaking)
Feature PR Checklist
test.batsfile)Release PR Checklist
ecs-deployscriptRelease _._._ - Summary of change(using whateverthe new version number is, plus a succinct summary of what changed)