poc of use js front end to get loras list #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doombeaker
commented
Sep 27, 2024
| const shareid_widget = this.widgets.find(widget => widget.name === "share_id"); | ||
|
|
||
| if (shareid_widget) { | ||
| shareid_widget.callback = onTextChange; |
There was a problem hiding this comment.
前端的主要作用，是通过设置 shareid 那个文本框的回调，监控文本改变事件。
然后在文本改变的事件里，像后端发请求，得到 loras list
doombeaker
commented
Sep 27, 2024
showcase.py
Outdated
|
|
||
| share_id = data.get("share_id") | ||
| print(f"use {share_id} to get the loras_list...") | ||
| loras_list = ["flux/lora1.safetensors", "flux/lora2.safetensors"] |
There was a problem hiding this comment.
这个 loras_list 应该来自网络请求。 loras_list 建议放上一个默认的美甲模型，使得 loras_list 的长度一定是 >=1 的，这样前端的逻辑就完全不用改了
doombeaker
commented
Sep 27, 2024
showcase.py
Outdated
| @@ -119,3 +119,23 @@ async def get_file_content(request): | |||
| status=500, | |||
| content_type="application/json", | |||
| ) | |||
|
|
|||
|
|
|||
| @PromptServer.instance.routes.post("/bizyair/shareloras") | |||
There was a problem hiding this comment.
这段添加后端的代码，是临时放在这的。请根据需要挪到合适的地方。
ccssu
added a commit
that referenced
this pull request
Sep 29, 2024
* Add SharedLoraLoader node * poc of use js front end to get loras list (#156) * poc * refine * refine --------- Co-authored-by: FengWen <[email protected]> * fix SharedLoraLoader * Remove unused comments --------- Co-authored-by: Yao Chi <[email protected]>
doombeaker
added a commit
that referenced
this pull request
Sep 29, 2024
* share model * fix * Add SharedLoraLoader node (#154) * Add SharedLoraLoader node * poc of use js front end to get loras list (#156) * poc * refine * refine --------- Co-authored-by: FengWen <[email protected]> * fix SharedLoraLoader * Remove unused comments --------- Co-authored-by: Yao Chi <[email protected]> * refine message and add docs --------- Co-authored-by: dantegarden <[email protected]> Co-authored-by: FengWen <[email protected]> Co-authored-by: Yao Chi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.