bug: support array argument to labels() again #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Each pull request require an update in the CHANGELOG. Please update it based on your changes. |
This was undocumented and untested, and broke in 13.1.0. Fixes #499
@siimon @SimenB I'm somewhat inclined to not land this. This was undocumented and untyped, and it took 14 months for one user to notice this broke (between the time 13.1 was released and issue was opened). On the other hand, it's easy to support and the work is done. WDYT? |
|
I'm happy with reducing the API surface (i.e. not land this). However, we can throw an explicit error if an array is passed so the user is aware? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was undocumented and untested, and broke in 13.1.0.
I'm not sure why we provide 4 ways to set labels.
Fixes #499