conformance: add conformance CLI and action #287
Conversation
jleightcap
force-pushed
the
jl/conformance-suite
branch
4 times, most recently
from
38b72f1 to
6ced192
Compare
|
This looks really promising, thanks for having started the efforts on this topic! Do you want to get all the subcommands implemented in one single PR? I would personally be fine to take the code as it currently is and then slowly add the missing tests via dedicated PRs. In the meantime we can allow the GH actions running the conformance test suite to fail |
No strong preference from me 🙂 -- @jleightcap, if you'd to shore this up in its current state and break up the remaining work into subsequent PRs, that works for me. |
jleightcap
force-pushed
the
jl/conformance-suite
branch
from
e4a1816 to
0c845ed
Compare
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
jleightcap
force-pushed
the
jl/conformance-suite
branch
from
0c845ed to
d6a7b54
Compare
|
Thanks for the feedback 🙂 I've carved out this PR to just implement the CLI specification and add the conformance action. The action is currently attempting to run the test suite -- future PRs will cover that functionality then. |
jleightcap
changed the title
Signed-off-by: Jack Leightcap <[email protected]>
Signed-off-by: Jack Leightcap <[email protected]>
.github/workflows/conformance.yml
Outdated
| @@ -0,0 +1,21 @@ | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
Maybe we should leave that commented, at least until the full specification is implemented. Otherwise it could be confusing to see the failures happen on PR and on the main branch
There was a problem hiding this comment.
Makes sense to me -- perhaps we should make it workflow_dispatch for the time being, so that it isn't triggered automatically but can be still done manually.
There was a problem hiding this comment.
Yeah, this currently doesn't make sense. Thanks for the workflow_dispatch pointer @woodruffw (0e0ee5e)
Signed-off-by: Jack Leightcap <[email protected]>
jleightcap
force-pushed
the
jl/conformance-suite
branch
from
0e0ee5e to
f35ca2b
Compare
What's Changed ============== * chore(deps): Update rstest requirement from 0.17.0 to 0.18.1 by @dependabot in #282 * chore(deps): do not enable default features of chrono by @flavio in #286 * chore(deps): Update pem requirement from 2.0 to 3.0 by @dependabot in #289 * conformance: add conformance CLI and action by @jleightcap in #287 * chore: fix clippy warnings by @flavio in #292 * chore(deps): Bump actions/checkout from 3.5.3 to 3.6.0 by @dependabot in #291 * chore(deps): Update tough requirement from 0.13 to 0.14 by @dependabot in #290 * chore(deps): update to latest version of picky by @flavio in #293 * chore(deps): Bump actions/checkout from 3.6.0 to 4.0.0 by @dependabot in #294 * chore: add repository link to Cargo metadata by @flavio in #297 * chore(deps): Update cached requirement from 0.44.0 to 0.45.1 by @dependabot in #298 * chore(deps): Bump actions/checkout from 4.0.0 to 4.1.0 by @dependabot in #302 * chore(deps): Update cached requirement from 0.45.1 to 0.46.0 by @dependabot in #301 * chore(deps): Update testcontainers requirement from 0.14 to 0.15 by @dependabot in #303 * chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1 by @dependabot in #304 * cosign/tuf: use trustroot by @jleightcap in #305 * Fix broken tests, update deps by @flavio in #313 New Contributors ================ * @jleightcap made their first contribution in #287 **Full Changelog**: v0.7.2...v0.8.0 Signed-off-by: Luke Hinds <[email protected]> Co-authored-by: Flavio Castelli <[email protected]>
What's Changed ============== * chore(deps): Update rstest requirement from 0.17.0 to 0.18.1 by @dependabot in #282 * chore(deps): do not enable default features of chrono by @flavio in #286 * chore(deps): Update pem requirement from 2.0 to 3.0 by @dependabot in #289 * conformance: add conformance CLI and action by @jleightcap in #287 * chore: fix clippy warnings by @flavio in #292 * chore(deps): Bump actions/checkout from 3.5.3 to 3.6.0 by @dependabot in #291 * chore(deps): Update tough requirement from 0.13 to 0.14 by @dependabot in #290 * chore(deps): update to latest version of picky by @flavio in #293 * chore(deps): Bump actions/checkout from 3.6.0 to 4.0.0 by @dependabot in #294 * chore: add repository link to Cargo metadata by @flavio in #297 * chore(deps): Update cached requirement from 0.44.0 to 0.45.1 by @dependabot in #298 * chore(deps): Bump actions/checkout from 4.0.0 to 4.1.0 by @dependabot in #302 * chore(deps): Update cached requirement from 0.45.1 to 0.46.0 by @dependabot in #301 * chore(deps): Update testcontainers requirement from 0.14 to 0.15 by @dependabot in #303 * chore(deps): Bump actions/checkout from 4.1.0 to 4.1.1 by @dependabot in #304 * cosign/tuf: use trustroot by @jleightcap in #305 * Fix broken tests, update deps by @flavio in #313 New Contributors ================ * @jleightcap made their first contribution in #287 **Full Changelog**: v0.7.2...v0.8.0 Signed-off-by: Luke Hinds <[email protected]> Co-authored-by: Flavio Castelli <[email protected]>
Summary
Begins #178.
Release Note
Documentation