Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algorithm registry markdown and KnownSignatureAlgorithm enumeration #194

Merged
merged 18 commits into from
Jan 17, 2024

Conversation

tetsuo-cpp
Copy link
Contributor

As part of our work to support configurable crypto algorithms in Sigstore, we're adding both a markdown file documenting the supported algorithm combinations as well as a SupportedAlgorithm enumeration to support any code that operates on these algorithms.

docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
Signed-off-by: Alex Cameron <[email protected]>
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
protos/sigstore_common.proto Outdated Show resolved Hide resolved
@tetsuo-cpp tetsuo-cpp changed the title Add algorithm registry markdown and SupportedAlgorithm enumeration Add algorithm registry markdown and KnownSignatureAlgorithm enumeration Jan 17, 2024
woodruffw
woodruffw previously approved these changes Jan 17, 2024
Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits on the hash chocies

docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Outdated Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
docs/algorithm-registry.md Show resolved Hide resolved
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@woodruffw woodruffw merged commit 017af89 into sigstore:main Jan 17, 2024
25 checks passed
@woodruffw woodruffw deleted the alex/configurable-crypto branch January 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants