-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonschema: container fix, updated compilation options #121
Conversation
4fd0d68
to
97d6c37
Compare
Signed-off-by: Jack Leightcap <[email protected]>
e33eec0
to
6492e36
Compare
Dockerfile.jsonschema
Outdated
@@ -1,6 +1,6 @@ | |||
# 3.18.2 | |||
FROM alpine@sha256:82d1e9d7ed48a7523bdebc18cf6290bdb97b82302a8a9c27d4fe885949ea94d1 | |||
RUN apk add --update protoc=3.21.12-r2 protobuf-dev=3.21.12-r2 go=1.20.5-r0 git=2.40.1-r0 | |||
RUN apk add --update protoc=3.21.12-r2 protobuf-dev=3.21.12-r2 go=1.20.7-r0 git=2.40.1-r0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @znewman01 for consensus, but I'd personally be okay with removing these pins now that we understand how they interact with the surrounding alpine image: the image itself has a "world" pin that effectively pins each of these dependencies.
(In other words, the pins here are extraneous and only cause trouble when the alpine image is updated automatically and they aren't.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh okay. That makes me a little nervous about auto-updates of the image itself. But I guess any big changes due to updates would get caught by the generation tests.
So I say go ahead and remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; one comment that I want additional feedback from the other maintainers on 🙂
Signed-off-by: William Woodruff <[email protected]>
Summary
Closes #120, towards #118
Release Note
Documentation