Skip to content

Commit

Permalink
Clarify log index in transparency log entry vs inclusion proof (#101)
Browse files Browse the repository at this point in the history
* clarify log index in tle vs inclusion proof

Signed-off-by: Ceridwen Coghlan <[email protected]>

* ran make all

Signed-off-by: Ceridwen Coghlan <[email protected]>

* comment suggestion

Co-authored-by: Hayden B <[email protected]>
Signed-off-by: Ceridwen Coghlan <[email protected]>

* ran make all again

Signed-off-by: Ceridwen Coghlan <[email protected]>

---------

Signed-off-by: Ceridwen Coghlan <[email protected]>
Co-authored-by: Hayden B <[email protected]>
  • Loading branch information
Ceridwen Coghlan and haydentherapper authored Jul 26, 2023
1 parent 5b10d0f commit 265fd3a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions gen/pb-go/rekor/v1/sigstore_rekor.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/pb-typescript/src/__generated__/sigstore_rekor.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions protos/sigstore_rekor.proto
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ message Checkpoint {
// InclusionProof is the proof returned from the transparency log. Can
// be used for offline or online verification against the log.
message InclusionProof {
// The index of the entry in the log.
// The index of the entry in the tree it was written to.
int64 log_index = 1 [(google.api.field_behavior) = REQUIRED];
// The hash digest stored at the root of the merkle tree at the time
// the proof was generated.
Expand Down Expand Up @@ -90,7 +90,7 @@ message InclusionPromise {
// the response from Rekor) is similar to a Signed Certificate Timestamp
// as described here https://www.rfc-editor.org/rfc/rfc6962.html#section-3.2.
message TransparencyLogEntry {
// The index of the entry in the log.
// The global index of the entry, used when querying the log by index.
int64 log_index = 1 [(google.api.field_behavior) = REQUIRED];
// The unique identifier of the log.
dev.sigstore.common.v1.LogId log_id = 2 [(google.api.field_behavior) = REQUIRED];
Expand Down

0 comments on commit 265fd3a

Please sign in to comment.