Add explicit identity token argument to SigstoreSigner.
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches functionality in `sigstore-python`, allowing callers to provide an identity token provided out-of-band. https://github.com/sigstore/sigstore-python/blob/cac62e8e611d4286a49ecda7f33d356381ab7919/sigstore/_cli.py#L658-L665 Signed-off-by: Spencer Schrock <[email protected]>
|
I forgot the CLI part, I'll add it first |
mihaimaruseac
approved these changes
Nov 11, 2024
|
I'll send it as a follow up then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This matches functionality in
sigstore-python, allowing callers to provide an identity token provided out-of-band.https://github.com/sigstore/sigstore-python/blob/cac62e8e611d4286a49ecda7f33d356381ab7919/sigstore/_cli.py#L658-L665
Fixes #316
Release Note
Added an optional
identity_tokenargument to Sigstore signer classes, allowing users to specify which OIDC token to use.Documentation