Configure fulcio resources #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* createcerts job resources via `createcerts.resources` * add missing readme entry for fulcio container resources Signed-off-by: Vipul Agarwal <[email protected]>
Signed-off-by: Vipul Agarwal <[email protected]>
Signed-off-by: Vipul Agarwal <[email protected]>
Signed-off-by: Vipul Agarwal <[email protected]>
JAORMX
approved these changes
Jan 18, 2023
hectorj2f
approved these changes
Jan 18, 2023
k4leung4
reviewed
Jan 20, 2023
| @@ -86,6 +86,7 @@ helm uninstall [RELEASE_NAME] | |||
| | createcerts.image.version | string | `"sha256:73e7ac35d0e5169bd14a5cb6caed2e7d44277dec3d1de92e08f4d055523089a1"` | | | |||
| | createcerts.name | string | `"createcerts"` | | | |||
| | createcerts.replicaCount | int | `1` | | | |||
| | createcerts.resources | string | `""` | | | |||
There was a problem hiding this comment.
resources isnt a string, should this be an object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adding ability to configure k8s resource requests and limits in all the components of fulcio.
Existing or Associated Issue(s)
Additional Information
At present, we cannot configure resource requests and limits for some components like one time jobs, initContainers and some deployments via Sigstore helm charts. This becomes a problem when
ResourceQuotais defined for namespaces and prevents pods to spin up. It is a best practice to define resource requests and limits for all k8s resources.Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.