Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pending scaffolding portable Makefile in e2e test script #4117

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented Mar 17, 2025

sigstore/rekor-tiles#38

Summary

pending: sigstore/scaffolding#1517

  • Uses the new Makefile to startup fulcio and rekor containers.
    • we could use the Action, but we still want to be able to do all this locally, so we use the Makefile directly.
  • attaches the fakeoidc container to the fulcio network by the system's hostname, rather than ip.

Testing

./test/e2e_test.sh

The github action worklfow "CI-Tests"'s job "e2e-tests" uses this script and should pass.

Release Note

Documentation

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.45%. Comparing base (2ef6022) to head (0393fa5).
Report is 346 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4117      +/-   ##
==========================================
- Coverage   40.10%   36.45%   -3.65%     
==========================================
  Files         155      210      +55     
  Lines       10044    13736    +3692     
==========================================
+ Hits         4028     5008     +980     
- Misses       5530     8100    +2570     
- Partials      486      628     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
@jku
Copy link
Member

jku commented Mar 26, 2025

Can you describe the planned end state of this PR? Would this use the action from scaffolding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants