Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BitList::is_disjoint #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add BitList::is_disjoint #15

wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

Closes #14

@michaelsproul
Copy link
Member Author

Seems to be about 2.5x faster in micro-benchmarks, although the allocating variant is already very fast:

bitfield_is_disjoint/2048
                        time:   [107.90 ns 108.69 ns 109.38 ns]
Found 19 outliers among 100 measurements (19.00%)
  12 (12.00%) high mild
  7 (7.00%) high severe

bitfield_is_disjoint_by_intersection/2048
                        time:   [263.59 ns 264.14 ns 264.75 ns]
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

I'm going to test this out in Lighthouse block packing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitfield should have an is_disjoint method
1 participant