Fix encode TalkRequest regression during library transition #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jxs @AgeManning ping for review |
KolbyML
force-pushed
the
fix-regression
branch
from
7dcd740 to
190d01b
Compare
ackintosh
approved these changes
Jan 18, 2025
|
Yeah. This change cooked us also in a variety of ways, but it was outside the library. I thought I had caught them all, but we don't use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Well updating from the old rlp library to the new one alloy_rlp there was a regression for encoding/decoding TalkRequests, which is required for the Portal Network.
I noticed something was broken when trying to upgrade Trin to alloy back in Apr 5, 2024. I delayed upgrading ethereum/trin#1231 because I didn't have time to debug this issue at the time.
So here is the fix to the regression and a few tests to prevent it from happening again
Notes & open questions
Change checklist