Remove validation expect #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .operator_ids() | ||
| .first() | ||
| .expect("Confirmed to exist"); | ||
| let signer = wrapped_msg.signed_message.operator_ids().first()?; |
There was a problem hiding this comment.
Does it happen when operator_ids is empty? If so, should execution get to this point?
There was a problem hiding this comment.
This should never happen hence the expect. The fuzzing is very targeted.
My thought was that although this should never happen in practice, if the fuzzer can hit it then we should probably just handle it. Behavior is exactly the same.
Maybe there is also an argument that if this happens then we should panic and stop the node.
jking-aus
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/
Proposed Changes
Qbft fuzzing hits the expect. Just propagate option via
?instead of callingexpect