fix: Unspecified error when registering tray #116
Conversation
| result | ||
| } | ||
| } | ||
| .ok() |
There was a problem hiding this comment.
Why do you think a delay of 2 seconds is enough? Shouldn't it be repeated several times?
If Shell_NotifyIconW works in thread, after the first failure, it is better to open another thread and try again in it. It should not block the main thread, and the lack of trayicon does not affect its use.
ok() will call getLastError internally, and you have called it yourself. Won't this cause problems?
Recommand to only use ok() to obtain the execution result and do not call GetLastError manually.
There was a problem hiding this comment.
- According to the Failed to add trayicon, Unspecified error (0x80004005) #111 discussion, if the
tray windowof the device is not ready after 2 secs, then it is certain that the device is too behind. - I don’t think anyone will switch windows within 2-5 secs after booting or login. so There is no need to process it asynchronously.
- Calling GetLastError multiple times in the same thread will always get the same value until a new error occurs.
The only thing worth discussing is the number of secs of delay, it could be one of 2,3,4,5, but should not be more than 5.
We don't have to consider it works on devices that should be eliminated.
|
#117 is a more reasonable solution. |
see #111