New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: discontinue `rag_min_score_*` config items #1081

Merged

sigoden merged 1 commit into main from feat-rag-min-score

Jan 10, 2025

Owner

sigoden commented Jan 10, 2025

We will be discontinuing the rag_min_score_* configuration items.

Reasons:

Their functionality overlaps with rag_top_k, and they are not as efficient or flexible as rag_top_k.
Scores generated by different embedding models vary, making it impossible to configure them uniformly.
Scores can only be inspected through debug logs, which is overly complicated.


          feat: discontinue rag_min_score_* config items

sigoden merged commit 486ee57 into main

3 checks passed

sigoden deleted the feat-rag-min-score branch

January 10, 2025 09:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet