Skip to content

Commit

Permalink
Merge pull request #147 from signnow/fix-validation
Browse files Browse the repository at this point in the history
Fix validation limits, add thumbnails
  • Loading branch information
AlexNDRmac committed Jan 23, 2023
2 parents c527e88 + 54c0b45 commit fd17024
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 44 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,18 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
and this project adheres to [Semantic Versioning](http://semver.org).

## [Unreleased] - TBD


## [1.1.0] - 2023-01-23
### Added
- The `Thumbnail` property on `Model.SignNowDocument`, which allows you to get document thumbnails in small, medium and large image sizes

### Fixed
- Fixed fails when parsing error response from auth service [#134](https://github.com/signnow/SignNow.NET/issues/134)

### Changed
- Removed built-in validation for `LinkExpiration`


## [1.0.0] - 2022-02-26
### Added
Expand Down Expand Up @@ -155,7 +161,8 @@ and this project adheres to [Semantic Versioning](http://semver.org).
[create freeform invite]: https://github.com/signnow/SignNow.NET/blob/develop/README.md#create-freeform-invite


[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.0.0...HEAD
[Unreleased]: https://github.com/signnow/SignNow.NET/compare/1.1.0...HEAD
[1.1.0]: https://github.com/signnow/SignNow.NET/compare/1.0.0...1.1.0
[1.0.0]: https://github.com/signnow/SignNow.NET/compare/0.9.0...1.0.0
[0.9.0]: https://github.com/signnow/SignNow.NET/compare/0.8.0...0.9.0
[0.8.0]: https://github.com/signnow/SignNow.NET/compare/0.7.0...0.8.0
Expand Down
27 changes: 0 additions & 27 deletions SignNow.Net.Test/UnitTests/Requests/CreateEmbedLinkOptionsTest.cs

This file was deleted.

16 changes: 1 addition & 15 deletions SignNow.Net/Model/Requests/CreateEmbedLinkOptions.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
using System.Runtime.Serialization;
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
using SignNow.Net.Exceptions;

namespace SignNow.Net.Model.Requests
{
Expand All @@ -21,19 +19,7 @@ public class CreateEmbedLinkOptions
/// In how many minutes the link expires, ranges from 15 to 45 minutes or null.
/// </summary>
[JsonProperty("link_expiration")]
public uint? LinkExpiration
{
get { return linkExpiration; }
set
{
if (value < 15 || value > 45)
{
throw new ArgumentException(ExceptionMessages.AllowedRangeMustBeFrom15to45, nameof(LinkExpiration));
}

linkExpiration = value;
}
}
public uint? LinkExpiration { get; set; }

/// <summary>
/// Signature invite you'd like to embed.
Expand Down
2 changes: 1 addition & 1 deletion SignNow.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>

<Version>1.0.0</Version>
<Version>1.1.0</Version>
<Authors>signNow</Authors>
<Company>signNow</Company>
<Description>signNow.Net is a .NET 4.5+ and .NET standard class library for the signNow API. (Official Library)
Expand Down

0 comments on commit fd17024

Please sign in to comment.