Add click-to-deselect conversation functionality #7470
+160
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
main
branchpnpm run ready
run passes successfully (more about tests here)Description
This PR adds click-to-deselect conversation functionality to the Signal Desktop LeftPane, providing users with an intuitive way to clear conversation selections by clicking empty areas. Semi-relevant issue here #1784
User Value
Cmd+Shift+C
keyboard shortcutWhat Changed
handleLeftPaneClick
event handler toLeftPane.tsx
event.target.closest()
showConversation({ conversationId: undefined, messageId: undefined })
to deselectLeftPane_test.ts
Technical Implementation
event.target.closest()
to detect clicks on buttons, inputs, conversation items, etc.preventDefault()
andstopPropagation()
for clean event handlingTest Approach
Manual Testing:
Cmd+Shift+C
keyboard shortcut still works as expectedAutomated Testing:
Operating Systems:
Additional Testing: