Do not close FunPanelEmojis on ClickEvent #7432
Open
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Professorq
force-pushed
the
keep-emoji-picker-open-on-selection
branch
2 times, most recently
from
f00fab2 to
ac7e67a
Compare
On cinnamon clicking (using a mouse) on an emoji sends a PointerEvent with pointerType `pen`, causing the emoji picker to close.
Professorq
force-pushed
the
keep-emoji-picker-open-on-selection
branch
from
ac7e67a to
fe2e3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
On cinnamon clicking (using a mouse) on an emoji sends a PointerEvent with pointerType
pen, causing the emoji picker to close. Fixes #7269This check for event modifier keys and pointerType seem to be carryovers from prior implementation of this callback, which handled a PressEvent. Any of the standard ClickEvent pointer types (
pen,mouse,touch) should trigger the same behavior: selecting an emoji, and keeping the popover open. Even an empty-string or vendor-prefixed event should probably also share this behavior.Manually tested by opening the emoji picker and selecting an emoji. Picker does not dismiss, accepts multiple emojis until dismissed.
Long-clicked on skin-tonable emoji to bring up skin tone popover. Clicking on skin tone popover also dismisses the emoji picker, which is consistent with the behavior before this change.
Emoji in message text line include gender and skin tone.
Tested on Ubuntu 24.04.2 LTS, running cinnamon/noble (6.0.4-4)