Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Allow local contact import to work on Cyanogen. #102

Closed

Conversation

patcon
Copy link

@patcon patcon commented Jul 8, 2015

Fixes #85

AOSP uses a null ACCOUNT_TYPE for local contacts, whereas it seems CM
uses com.android.localphone.

I don't have an android dev environment set up on my current workstation, so this is untested :(

AOSP uses a null ACCOUNT_TYPE for local contacts, whereas it seems CM
uses `com.android.localphone`.
@patcon
Copy link
Author

patcon commented Jul 8, 2015

Had to disable to nonplay build flavor (#94).

OK, guess that seemed too easy -- the correct contact count shows up on the import screen, but the the service doesn't actually seem to import anything. Guessing the null accounttype assumption is elsewhere :) I'll try digging a big more later

@patcon
Copy link
Author

patcon commented Jul 8, 2015

OK, reading through, wondering whether you would have any objection to treating CM's approach as the "right" one, and treating AOSP's "assume null is local" approach as the thing we work around? I feel like that might read a bit more sensibly

@patcon patcon closed this Mar 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant