WIP:Linked Project Calendar #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| public void onPageRequest(final PageRequest request) { | ||
| final Map<Integer, Integer> calendars = new HashMap<Integer, Integer>(); | ||
| Integer CalendarId = 1; |
There was a problem hiding this comment.
The Java naming convention encourage naming variables with a first letter as lowercase .
CalendarId should be spelled calendarId.
There was a problem hiding this comment.
@Raphcal Done it.Thank You.
| calendars.put(1, getOrgUnit().getId()); | ||
| calendars.put(2, getOrgUnit().getCalendarId()); | ||
| public void onPageRequest(final PageRequest request) { | ||
| final Map<Integer, Integer> calendars = new HashMap<Integer, Integer>(); |
There was a problem hiding this comment.
@spMohanty & @osarrat Organization calendar integration is done only in one way.That means parent calendar contains child entries while child does not contain any parent entry.Is this okay or should it be both way ?
There was a problem hiding this comment.
Yes, that is the expected behavior as expressed in issue #522 : http://www.sigmah.org/issues/view.php?id=522
| calendars.put(calendarId, getOrgUnit().getChildrenOrgUnits().iterator().next().getCalendarId()); | ||
| iter.next(); | ||
|
|
||
| for(final OrgUnitDTO child : getOrgUnit().getChildrenOrgUnits()) { |
There was a problem hiding this comment.
@Raphcal Changed to for loop as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is halfway work for Issue 521.
This commit completes the integration of other related project calendar.a little GUI work is left.