fix FileNotFoundError when installing irust_kernel #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileNotFoundError: [Errno 2] No such file or directory: 'target/release/examples/re'
|
Thanks nice catch! Unfortunately this breaks $CARGO_TARGET_DIR workflow, can you try this instead subprocess.run(["cargo", "b", "--release", "--example", "re", "--target-dir",cargo_target_dir, "--manifest-path", os.path.join(irust_repl_dir,"Cargo.toml")])and if it works update the pr with it |
|
Yeah, sure. Thanks for pointing out. |
|
I've tested it, and it worked. Update the PR accordingly. |
|
thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking into the crates/irust_repl/irust_kernel/irust_kernel/install.py, I found only a missing path
irust_repl_dirwhile declaringsrc = os.path.join(cargo_target_dir, "release", "examples", "re")on line 51.Since on line 49, set the cwd to
irust_repl_dir.So, I created this pull request to address #123 and the installation works perfectly.