Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strongly type get_configure_view #49

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

reneluria
Copy link

@reneluria reneluria commented Aug 20, 2024

cf. getsentry/sentry#75395

to be compatible with 24.8.0

fixes #50

@max-wittig
Copy link
Member

Looks good to me. I will try it out soon. We have not yet upgraded to 24.8.0, but will do so soon!

@max-wittig max-wittig self-assigned this Aug 23, 2024
@max-wittig
Copy link
Member

Hi! Sorry for the late response. We got lots of stuff going on at the moment.

As you're updating this month. Do you mind taking a look, when you do? @dlouzan

@dlouzan dlouzan self-assigned this Sep 12, 2024
@dlouzan
Copy link
Member

dlouzan commented Sep 12, 2024

@reneluria Thanks for the contribution! I'm currently checking this on our stage system, we also need it for sentry 24.8.0 👍

Copy link
Member

@dlouzan dlouzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reneluria Thanks, just did an initial pass, please take a look.

oidc/provider.py Outdated Show resolved Hide resolved
oidc/views.py Show resolved Hide resolved
oidc/views.py Outdated Show resolved Hide resolved
@dlouzan
Copy link
Member

dlouzan commented Sep 12, 2024

@reneluria We will also need a fix of the test setup to be able to run the test suite. Let me know if you're willing to take care of the required work, or we should take over.

@dlouzan
Copy link
Member

dlouzan commented Sep 12, 2024

@reneluria Thanks for addressing the open threads, we'll be merging this one now as our internal tests worked. There will be a new release once we fix the test setup, which we are doing in #51.

@reneluria
Copy link
Author

@reneluria Thanks for addressing the open threads, we'll be merging this one now as our internal tests worked. There will be a new release once we fix the test setup, which we are doing in #51.

excellent, thank you

@dlouzan dlouzan merged commit df07034 into siemens:master Sep 12, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with get_configure_view
3 participants