-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: strongly type get_configure_view #49
Conversation
Looks good to me. I will try it out soon. We have not yet upgraded to 24.8.0, but will do so soon! |
Hi! Sorry for the late response. We got lots of stuff going on at the moment. As you're updating this month. Do you mind taking a look, when you do? @dlouzan |
@reneluria Thanks for the contribution! I'm currently checking this on our stage system, we also need it for sentry 24.8.0 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reneluria Thanks, just did an initial pass, please take a look.
@reneluria We will also need a fix of the test setup to be able to run the test suite. Let me know if you're willing to take care of the required work, or we should take over. |
@reneluria Thanks for addressing the open threads, we'll be merging this one now as our internal tests worked. There will be a new release once we fix the test setup, which we are doing in #51. |
excellent, thank you |
cf. getsentry/sentry#75395
to be compatible with 24.8.0
fixes #50