mountpoint expects path instead of self.device #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombourger
reviewed
Mar 23, 2021
mtda/sdmux/helpers/image.py
Outdated
Comment on lines
269
to
270
| path = None | ||
| mountpoint = self._mountpoint(path) |
There was a problem hiding this comment.
mountpoint = self._mountpoint()
(path is optional)
There was a problem hiding this comment.
@chombourger ,
Presently we face issue AttributeError: 'SamsungSdMuxController' object has no attribute 'device' from sdmux/helpers/image.py.
Presently following attributes are defined in Class
SamsungSdMuxController(Image):
def init(self, mtda):
super().init(mtda)
self.file = "/dev/sda"
self.serial = "sdmux"
As file also corresponds to device will it be okay to change file to device or should we add new attribute "device" for SamsungSdMuxController
fixes: AttributeError: 'SamsungSdMuxController' object has no attribute 'device' Signed-off-by: Mayuri Mohite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: AttributeError: 'SamsungSdMuxController' object has no attribute 'device'
Signed-off-by: Mayuri Mohite [email protected]