fix(core/dropdown|dropdown-button): reflect disabled attribute in DOM when disabled property changes and support aria-disabled

[lakshmi-priya-b]

💡 What is the current behavior?

• When the dropdown-item or dropdown-button is set to disabled dynamically,When looking into the DOM it only has a class of "disabled", not the attribute "disabled"
• No support for aria-disabled

GitHub Issue Number: #2114

🆕 What is the new behavior?

• Now whenever if we set the disabled property both statically or dynamically the property is being reflected in the dom.
• Supports aria-disabled

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

• 🦮 Accessibility (a11y) features were implemented
• 🗺️ Internationalization (i18n) - no hard coded strings
• 📲 Responsiveness - components handle viewport changes and content overflow gracefully
• 📕 Add or update a Storybook story
• 📄 Documentation was reviewed/updated siemens/ix-docs
• 🧪 Unit tests were added/updated and pass (pnpm test)
• 📸 Visual regression tests were added/updated and pass (Guide)
• 🧐 Static code analysis passes (pnpm lint)
• 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3bc3488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @lakshmi-priya-b, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the disabled property of dropdown components (ix-dropdown-button and ix-dropdown-item) was not consistently reflected as an attribute in the DOM, impacting both visual state and accessibility. The changes ensure that the disabled attribute is properly reflected and introduce aria-disabled support, significantly improving the usability and accessibility of these components.

Highlights

• DOM Reflection of Disabled State: The disabled attribute for ix-dropdown-button and ix-dropdown-item now correctly reflects in the DOM when the disabled property is set, whether statically or dynamically. Previously, only a CSS class was applied, which could lead to inconsistencies or issues with styling and scripting that rely on the attribute's presence.
• Accessibility Support: Added support for the aria-disabled attribute to ix-dropdown-button and ix-dropdown-item components. This enhancement improves accessibility by explicitly communicating the disabled state to assistive technologies, ensuring a better experience for users with disabilities.
• New Regression Tests: Comprehensive regression tests have been added for both ix-dropdown-button and ix-dropdown-item to verify the correct reflection of the disabled attribute in the DOM and the proper application of the aria-disabled attribute, ensuring the new behavior is robust and stable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the reflection of the disabled property to a DOM attribute for ix-dropdown-button and ix-dropdown-item, and adds support for aria-disabled. The changes are well-tested. I've found a related issue in ix-dropdown-item where the inner button was not being disabled, preventing the component from being fully non-interactive. I've also suggested some minor cleanups in the new test files to improve their clarity. Overall, great work on improving accessibility and behavior consistency.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud