Skip to content

Conversation

kathrinschalber
Copy link
Collaborator

@kathrinschalber kathrinschalber commented Aug 26, 2025

Jira issue: IX-3140

  • UX Review
  • Dev Review
  • Final edit

Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit 28ca1eb
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/68df9bbde0ba3300084a831b
😎 Deploy Preview https://deploy-preview-79--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@flxlst09 flxlst09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide looks good to me, thanks. I wonder if we have any note on the component pages for the pane and drawer mentioning the deprecation as well?

- moved drawer markdowns to legacy
- fixed links
- added migration guide to sidebar
- fixed wrong quotation marks
- fixed grammar mistakes
flxlst09
flxlst09 previously approved these changes Aug 29, 2025
@kathrinschalber kathrinschalber changed the title Create migration guide for drawer Create migration guide Sep 11, 2025
@kathrinschalber kathrinschalber mentioned this pull request Sep 11, 2025
2 tasks
Standardized the capitalization of 'V4' throughout the migration guide for consistency.
tokyojen
tokyojen previously approved these changes Sep 11, 2025
Revised instructions for replacing basic and map navigation elements, recommending use of ix-application and related components. Removed legacy theme section and improved formatting for clarity.
@kathrinschalber kathrinschalber marked this pull request as ready for review September 16, 2025 16:14
Documented the change in ix-application-header height from 2.75rem (44px) to 3rem (48px) in the 4.0.0 migration guide.
Base automatically changed from release/v4.0.0 to main September 30, 2025 11:57
kathrinschalber and others added 2 commits September 30, 2025 14:13
Eliminated a redundant 'components/charts-overview/index' item from the Charts section in the sidebar configuration to prevent duplication.
@danielleroux
Copy link
Collaborator

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new migration guide and a blog post for the V4.0.0 release. The changes are comprehensive and well-structured. My review focuses on improving the clarity, consistency, and correctness of the new documentation. I've pointed out a few areas for improvement, such as fixing a typo, resolving a 'TBD' placeholder, and standardizing link formats. Additionally, I've identified a duplication issue in the sidebar configuration that should be addressed.

kathrinschalber and others added 2 commits October 1, 2025 09:52
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Eliminated repeated 'Drawer' tab items under 'legacy/drawer/index' in the sidebar configuration to avoid redundancy.
@flxlst09 flxlst09 self-requested a review October 1, 2025 09:06
flxlst09
flxlst09 previously approved these changes Oct 1, 2025
Copy link
Collaborator

@flxlst09 flxlst09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathrinschalber Changes approved, I will add another commit on AG Grid migration guide

Added the new UX writing formatting guidelines
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments 😇


![angular20](./2510_blog_angular.png)

This release brings full compatibility with Angular 20, helping teams keep their projects aligned with the latest framework improvements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This release brings full compatibility with Angular 20, helping teams keep their projects aligned with the latest framework improvements.
This release brings full compatibility with Angular 20 and up, helping teams keep their projects aligned with the latest framework improvements.


![Elevation principle](https://www.figma.com/design/wEptRgAezDU1z80Cn3eZ0o/iX-Documentation-illustrations?node-id=6707-50604&t=bGky2tHjBPC9fOGT-4)

<div class="table-full-width table-column-equal-width">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group is missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean our group component? Btw, I've also added the event list, and replaced the big table with a simple bullet list to avoid repetitive content

Refines language in the 2025-10-01 release blog and 4.0.0 migration guide for clarity and accuracy. Updates Angular peer dependency requirements, clarifies AG Grid Figma library changes, and improves instructions for button and elevation variant migrations.
Updated the release notes to specify compatibility with Angular 20 and up, instead of just Angular 20, to better reflect the supported versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants