Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'objectProto' option to create parsed objects as {} #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

egargan
Copy link

@egargan egargan commented Oct 27, 2021

Fixes #39.

This gives us the option of going back to the old object parsing behaviour, before c85a430, where any parsed object was created as {}.

This gives clients the ability to go back to the old behaviour
before c85a430, where any parsed object was created as {}.
@guilleasz-glovo
Copy link

This PR seems really useful, is there any plan to merge it?

@Targma
Copy link

Targma commented Feb 21, 2022

I really need this functionality, else we need to wrap function with
Object.assign({}, parsedObject).
Performance is important in project and with this we would avoid another copy.

@egargan
Copy link
Author

egargan commented Feb 21, 2022

I've emailed the owner but haven't heard anything back, we might be waiting a while!

@btnkr
Copy link

btnkr commented Oct 19, 2023

still hope merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object parse using json-bigint doesn't have Object function
4 participants