feat: external volumes #12255
Draft
feat: external volumes #12255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
external-volumes
branch
from
a4458c1 to
5b1f701
Compare
frezbo
reviewed
Nov 19, 2025
| // NFSMountConfig defines the interface to access NFS mount configuration. | ||
| type NFSMountConfig interface { | ||
| Version() string | ||
| Addr() optional.Optional[net.IP] |
Member
There was a problem hiding this comment.
shouldn't we also support dns names?
frezbo
reviewed
Nov 19, 2025
| const ( | ||
| NFSVersionType4_2 NFSVersionType = iota // 4.2 | ||
| NFSVersionType4_1 // 4.1 | ||
| NFSVersionType4 // 4 |
Member
Author
There was a problem hiding this comment.
Nah, it's far from being done. I just wanted to checkpoint the work :D
shanduur
force-pushed
the
external-volumes
branch
7 times, most recently
from
89716f5 to
e010ef0
Compare
Add new volume type for managing external volume mounts - e.g. NFS or Virtiofs volumes Signed-off-by: Mateusz Urbanek <[email protected]>
shanduur
force-pushed
the
external-volumes
branch
from
e010ef0 to
d825790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new volume type for managing external volume mounts - e.g. NFS or Virtiofs volumes
Fixes #10995
Signed-off-by: Mateusz Urbanek [email protected]