fix(hud): avoid horizontal scrollbar when recording on Windows#328
fix(hud): avoid horizontal scrollbar when recording on Windows#328AmirYunus wants to merge 1 commit intosiddharthvaddem:mainfrom
Conversation
Use full-size layout and overflow clipping instead of 100vw/100vh on the HUD shell so the fixed 600×160 overlay does not gain a horizontal scrollbar when recording widens the toolbar. Fixes siddharthvaddem#305
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughFixes horizontal and vertical scrollbar artifacts by adjusting layout sizing and CSS overflow properties. LaunchWindow uses container-relative dimensions instead of viewport-fixed sizing, while App applies HUD overlay styling to suppress overflow on root elements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Fixes an unwanted horizontal scrollbar on the recording HUD (the small bottom overlay) on Windows, which appeared after starting a recording when the toolbar widened to show the stop control, timer, and restart button.
The HUD is a fixed 600×160
BrowserWindow(electron/windows.ts). The renderer no longer uses100vw/100vh(w-screen/h-screen) for the HUD root. It now usesh-full/w-fullwithmin-w-0,max-w-full, and overflow clipping. Thehud-overlaydocument shell is also pinned to the window viahtml/body/#rootheight and hidden overflow so the layout matches the real viewport.Motivation
Users on Windows 10 with v1.3.0 saw a horizontal scrollbar on the HUD after recording started, even though the overlay should stay within its fixed window. Viewport units and unconstrained overflow produced extra horizontal scroll when the recording controls widened the bar. This change aligns the DOM with the fixed Electron window and removes that overflow.
Type of Change
Related Issue(s)
Fixes #305
Testing
npm run lint npm test npx tsc --noEmitTo verify the fix: run the app on Windows, open the HUD, select a source, start recording, and confirm no horizontal scrollbar appears on the HUD overlay.
Checklist
Summary by CodeRabbit
Release Notes