docs: add ATTRIBUTION.md for Recordly zoom animation code#273
docs: add ATTRIBUTION.md for Recordly zoom animation code#273ekkoitac wants to merge 1 commit intosiddharthvaddem:mainfrom
Conversation
- Update ATTRIBUTION.md to list clamp01() alongside easeOutScreenStudio() and cubicBezier() - Add inline attribution header comment to mathUtils.ts - Add inline attribution header comment to zoomRegionUtils.ts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request adds attribution documentation for zoom and pan animation code ported from Recordly. A new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is a little over the top when you could do something like this
this is not funny and overly bombastic. will be closing it. reopen with something like #260. original author already credited them with their PR: #207 you can check the description edit history. I cannot control what people choose to edit and incorporate. The creator of recordly is very well aware of every small detail happening in this repo since hes actively lurking and leaving comments/ prs and closing them. he replied on the very PR that introduced this change (half of which was heavily scrutinized and dismissed from being added upstream). |
Summary
Add attribution crediting Recordly for the zoom & pan animation system ported into OpenScreen, as requested in #263.
Changes
ATTRIBUTION.md— lists Recordly as the source of the zoom/pan animation code (mathUtils.tsandzoomRegionUtils.ts)README.md— added Attribution section linking toATTRIBUTION.mdmathUtils.tsandzoomRegionUtils.ts— added// Ported from Recordlycomment headers per reviewclamp01()added to the attribution entry per reviewFixes: #263
Summary by CodeRabbit