-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to composite mass modeling #26
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 99.35% 99.33% -0.03%
==========================================
Files 44 44
Lines 2182 2262 +80
==========================================
+ Hits 2168 2247 +79
- Misses 14 15 +1
|
@williyamshoe, the formatting check is failing. You can run these commands locally and then push a commit to resolve this:
You can |
Co-authored-by: Anowar Shajib <[email protected]>
Co-authored-by: Anowar Shajib <[email protected]>
Co-authored-by: Anowar Shajib <[email protected]>
Co-authored-by: Anowar Shajib <[email protected]>
Co-authored-by: Anowar Shajib <[email protected]>
@williyamshoe, thanks a lot for making the changes! Are you done implementing them, or is it still in progress? |
Yup, I'm done implementing the changes! |
@williyamshoe, looks good to me, except for I requested a docstring to be added. I also changed the method name to |
@williyamshoe, oops, I missed to check the coverage report before merging! Line 535 in kin_constraints_composite.py is missing coverage. If possible, can you make a quick PR to cover that line? |
Changes include: