Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for using npx instead of hardlinked eslint command #15

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

JackBailey
Copy link
Contributor

@JackBailey JackBailey commented Aug 12, 2023

This PR adds the option useNpx, which will change the following command:
node node_modules/.bin/eslint **/*.js to npx eslint **/*.js, which doesn't break when using pnpm (Resolves #14).

This PR is currently functional, but I'm sure you'll want to edit the code to your liking and write some documentation for it.

Usage:

- name: Lint
  uses: jackbailey/action-eslint@6494c60dd93dbb092144ca58dbf0ca14e85e4574
  with:
      token: ${{ secrets.GITHUB_TOKEN }} # optional
      extensions: 'js'
      annotations: true
      use-npx: true

@sibiraj-s sibiraj-s merged commit 2e3213f into sibiraj-s:master Aug 21, 2023
1 check passed
@JackBailey JackBailey deleted the eslint-command branch August 21, 2023 08:24
@Smef
Copy link

Smef commented Oct 18, 2024

This would be helpful to have released. Could we get a 3.0.2 release with this included, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] missing ) after argument list when using pnpm
3 participants