Skip to content

Commit

Permalink
Update node version in CI and in README (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
ento authored Aug 12, 2024
1 parent 5580b04 commit 3b24012
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Lint

env:
NODE_VERSION: 18
NODE_VERSION: 20

on:
pull_request:
Expand All @@ -13,8 +13,8 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
Expand Down
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
eslint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- run: npm ci # or yarn install
- uses: sibiraj-s/action-eslint@v3
with:
Expand Down Expand Up @@ -73,7 +73,7 @@ The `working-dir` option can be especially useful when the eslint installation i

```yml
steps:
- uses: action@v2
- uses: sibiraj-s/action-eslint@v3
with:
working-dir: apps/website
```
Expand All @@ -88,7 +88,7 @@ such as when a change is made to the `.eslintrc` file, where you may want to lin

```yml
steps:
- uses: action@v2
- uses: sibiraj-s/action-eslint@v3
with:
all-files: true
```
Expand All @@ -97,7 +97,7 @@ Note: When using this input, if the `eslint-args` has the `ignore-path` option t

```yml
steps:
- uses: action@v2
- uses: sibiraj-s/action-eslint@v3
with:
all-files: true
eslint-args: '--ignore-path=.gitignore --quiet'
Expand All @@ -108,8 +108,8 @@ Example to Run lint on all files when `.eslintrc` changes

```yml
steps:
- uses: actions/checkout@v3
- uses: dorny/paths-filter@v2
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -119,7 +119,7 @@ steps:
# run eslint on all files if eslintrc changes
- name: Run eslint on changed files
if: steps.filter.outputs.eslintrc == 'false'
uses: sibiraj-s/action-eslint@v2
uses: sibiraj-s/action-eslint@v3
with:
all-files: ${{ steps.filter.outputs.eslintrc == 'true' }}
```
Expand Down

0 comments on commit 3b24012

Please sign in to comment.