test codex#250
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // ✅ important: transform header keys to lower case because browsers send headers in lowercase | ||
| const entityKey = | ||
| entityName === 'headers' ? mappedEntityKey.toLowerCase() : mappedEntityKey; | ||
| const actualValue = request[entityName][entityKey]; |
There was a problem hiding this comment.
Route matching for headers/query/params now pulls actualValue directly from request[entityName][entityKey], whereas the previous implementation flattened the request object before comparison. Nested or dotted keys (e.g., entities: { query: { 'user.id': '42' } } or array indices from query/cookies) are no longer resolved and will always compare against undefined, causing routes that used to match nested values to fall through. Please reintroduce flattening or equivalent dotted-key resolution when evaluating non-body entities.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex you've left only one comment. Do full review for PR please. all comments
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // ✅ important: transform header keys to lower case because browsers send headers in lowercase | ||
| const entityKey = | ||
| entityName === 'headers' ? mappedEntityKey.toLowerCase() : mappedEntityKey; | ||
| const actualValue = request[entityName][entityKey]; |
There was a problem hiding this comment.
createRestRoutes now reads request[entityName][entityKey] directly without flattening the request object (lines 114‑116), but the previous implementation flattened it. Route configs that use dotted keys to match nested params/query/header values (e.g., { query: { 'user.id': 1 } } for a request parsed as { user: { id: '1' } }) will now see actualValue as undefined and fail to match. This breaks existing configs that depend on nested keys for non-body entities.
Useful? React with 👍 / 👎.
2 participants
No description provided.