#63 into [email protected] ☄ rework not cors middleware, add case for request with credentials #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,78 @@ | |||
| const { startMockServer } = require('./dist'); | |||
MiaInturi
requested changes
Jun 30, 2024
Comment on lines
+10
to
+11
| const allowedHeaders = Object.keys(request.headers).join(', '); | ||
| const exposedHeaders = Object.keys(request.headers).join(', '); |
There was a problem hiding this comment.
- exposed-headers это хэдеры ответа, так что брать их из запроса нет смысла. Думаю просто не имеет смысла сетить exposed-headers если пользователь явно их не задал через конфиг.
- allowed-headers можно вычислять только внути условия
isPreflightRequestи брать из заголовкаaccess-control-request-headers(как собственно и allow-methods)
There was a problem hiding this comment.
Ну и оба эти пункта должны относиться и к corsMiddleware ИМХО
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.