Fix typeof #9
Closed
Fix typeof #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibelius
reviewed
Dec 23, 2016
| @@ -1,6 +1,6 @@ | |||
| import 'babel-polyfill'; | |||
|
|
|||
| const fetch = typeof window === 'object' ? window.fetch : global.fetch; | |||
| const fetch = window === 'object' ? window.fetch : global.fetch; | |||
There was a problem hiding this comment.
I don't think this test is right
|
@annelorraineuy tks for the work on sending this PR just looked in some github issues in the best approach is to not use babel-polyfill and to not check for fetch as well this is the solution 787f02e if u wanna contribute to this package you can try to add some tests using jest #3 (http://facebook.github.io/jest/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usages of typeof. Not sure why the src folder was deleted but I put it back. Tested this on my own project which points to my fork of this repo and the validation is working. This is my first time doing this so let me know if there are issues.