Auto-test #17
Open
Auto-test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing `defined` in preprocessor test When `HAS_CLOCK_GETTIME_NSEC_NP` is not defined, `#elif HAS_CLOCK_GETTIME_NSEC_NP` triggers a warning * Include `caml/config.h` before `HAS_GETTIMEOFDAY` is tested Also remove a duplicate `errno.h`
When building a cross-compiler, the runtime will run on the target, not the host so: - set `cross_compiling` by comparing `build` to `target` (rather than to `host`), as this variable will be used later - use `target` to set up the tool prefix, - as the libtool configuration will configure a `build` to `host` toolchain, temporarily assign `host*` values to `target*` values
Instead of using `strip` unconditionally to build `tmpheader.exe`, use the `strip` command detected by `libtool` during configure so that it is replaced with `:` when the command is absent and it becomes easy to override it if need be
GNU strip can be called safely on binaries generated by cl as well as by MinGW GCC (even if it doesn't produce a smaller executable for cl-generated binaries) so invoke strip also on Windows so that MinGW binaries are properly stripped Tested with GNU strip 2.42
Allow the use of *-*-ocaml or *-*-*-ocaml target triplets to stand for freestanding cross-compilers by temporarily rewriting the target OS to `none` when generating the canonical target This allows to use *-*-ocaml and *-*-*-ocaml prefixes for cross-compiler specific toolchains, so that all the specific tools (for instance aarch64-solo5-ocaml-gcc, etc.) are automatically discovered
Make sure that we don't detect zstd on build when we are building a cross-compiler, as the native zstd has no reason to be compatible with the cross toolchain
Define cross.opt and cross-install targets FIXME: Problems of inconsistencies between compilation options (only about zstd?) between the native toolchain and the cross toolchain may break the build?
Solo5 is single-core with no scheduler, so avoid the useless memory waste Note that since PR#13272 the maximum number of domains can set using a parameter in OCAMLRUNPARAM so `getenv` might be a better place to set this limit in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.