Repository navigation
Fix CI test races - #26
Merged
Merged
Conversation
On Linux a reset discards records the client has not read yet, so the count before it is the kernel's to decide and the test failed on every CI run while passing on macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The last REQ the Relay saw could be the paging query readStored sends after EOSE, which carries an `until`, so the comparison failed whenever that query landed before the test looked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without a token, npm's dry run warns that publishing needs a login, and the check counted that as a manifest correction, so it passed only on a machine logged in to npm. A dry run checks only that a token is configured, so a dummy one in the unpacked package's .npmrc stands in and the corrections it was written for still surface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
blockchainluffy
approved these changes
Oct 27, 2026
ylembachar
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.