Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text slide #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

text slide #244

wants to merge 1 commit into from

Conversation

Felobateer
Copy link

@Felobateer Felobateer commented Sep 25, 2023

Hey @shravan20 I added a new animation to the index.js file in the animation folder in Utils and connected it to the text field.

I never worked with material ui before so I hope I did a good job.

Summary by CodeRabbit

  • New Feature: Introduced a new animation style to the TextField component in TemplateCard, enhancing user interaction and visual appeal.
  • Bug Fix: Corrected syntax errors in the grow_out_in animation within the animations object, ensuring smooth and accurate animations.
  • Refactor: Improved the structure and readability of the animations object by refining indentation and formatting. Added a new "slide-text" animation for future use.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github-readme-quotes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 4:47am

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2023

Walkthrough

This update enhances the user interface by introducing new animations and improving code readability. The changes include the addition of a makeStyles import, creation of a new CSS class with animation, and an improved structure for the animations object.

Changes

File Path Summary
.../TemplateCard/index.js Introduced makeStyles import and created a new CSS class with animation. Applied this class to the TextField component and removed extra spaces in the Paper component style.
.../util/animation/index.js Improved the structure and correctness of the animations object. Fixed syntax error in grow_out_in animation and added a new "slide-text" animation.

🐇💻

"In the land of code where the shadows lie,

We dance with the keys, under the digital sky.

With each tap and click, a story unfolds,

Of animations bright, and tales yet untold.

So here's to the changes, big and small,

To the rabbit coder, who hopped through it all!" 🎉🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Commits Files that changed from the base of the PR and between 67dcc38 and df9ae40.
Files selected for processing (2)
  • frontend/src/components/organisms/TemplateCard/index.js (4 hunks)
  • frontend/src/util/animation/index.js (2 hunks)
Files skipped from review due to trivial changes (1)
  • frontend/src/util/animation/index.js
Additional comments (Suppressed): 2
frontend/src/components/organisms/TemplateCard/index.js (2)
  • 57-61: The new useStyles function creates a CSS class with animation, which is then applied to the TextField component. This enhances the user interface by adding an animation effect to the text field.

  • 92-95: The TextField component now has a new CSS class textFieldWithAnimation applied to it. This class adds an animation effect to the text field when it is rendered.

Comment on lines 8 to 21
Slide,
CircularProgress,
} from "@material-ui/core";
import { makeStyles } from "@material-ui/core/styles";
import getTemplate from "../../../util/template/getTemplate";
import Template from "../../../util/template/Template";
import mainLayouts from "../../../util/layouts";
import mainAnimations from "../../../util/animation";
import mainThemes from "../../../util/themes";
import mainFonts from "../../../util/fonts";
import animations from "../../../util/animation";

const TemplateCard = (props) => {
const [showSnackbar, setShowSnackbar] = useState(false);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for animations from "../../../util/animation" is duplicated. The animations are already imported as mainAnimations on line 15. You should remove the duplicate import.

- import animations from "../../../util/animation";

Copy link
Owner

@shravan20 shravan20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Felobateer :D

Thank you for your amazing contribution!! Really appreciate your efforts and time taken to contribute :)

Can you address the PR comment provided by coderabbitai?

@shravan20
Copy link
Owner

@Felobateer Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants