Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate item weight and display rocket capacity #387

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

DaleStan
Copy link
Collaborator

This loads or calculates the weight of each item and displays the rocket capacity in the item tooltips. I don't think this completes either #369 or #381, but it loads data needed for them.

The calculations done by Factorio aren't documented, but most of my results match at least one of https://rocketcal.cc/weights.json or Factorio. (I skipped some harder-to-acquire items, such as the spidertron rocket launchers, and all virtual items, such as artillery remotes.)

@DaleStan DaleStan requested review from veger and SWeini January 11, 2025 23:33
@DaleStan DaleStan requested a review from shpaass as a code owner January 11, 2025 23:33
Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature!

@shpaass
Copy link
Owner

shpaass commented Jan 20, 2025

Apologies for not including this one in 2.6.0. I forgot to merge it.
Will add this check in the release process.

@DaleStan DaleStan force-pushed the display-rocket-capacity branch from 03296cf to 3435182 Compare January 23, 2025 22:29
@DaleStan DaleStan requested a review from shpaass January 23, 2025 22:29
@DaleStan DaleStan force-pushed the display-rocket-capacity branch from 3435182 to 2c3654b Compare January 24, 2025 02:29
@shpaass
Copy link
Owner

shpaass commented Jan 24, 2025

Giving it a bit of time to get checked. Merging in 12-19 hours from now.

@shpaass shpaass merged commit a49113c into shpaass:master Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants