Scroll view for productivity tech levels #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows scroll viewers on tab controls to use all remaining height, without tedious height adjustments every time another tab changes.
veger
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #334 (comment) I said I wanted to see a scrolling list for the productivity tech levels, but I didn't realize that scroll views and tab controls didn't get along. They get along now, and the preferences screen won't get too tall with extra prod researches.
The first commit has a fix that should maybe have been its own PR? Trying to change the level of the scrap mining productivity research would toggle dark mode instead. (If you had a lot of milestones, it was steel smelting productivity instead.)