Should not prefer inaccessible recipes: Apply cost penalty #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By non-automatable goods, you mean the goods that cannot be crafted by anything else in the project, including disabled recipes? |
|
No, non-automatable goods means goods that show "YAFC analysis: Unable to find a way to fully automate this" in their tooltip. In vanilla, anything that depends on Wood is non-automatable, such as a shotgun or a wooden chest. (Or should be; Yafc decides wood is automatable for reasons that I haven't looked into.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two possible implementations of this fix, but neither is perfect. This one usually behaves as expected, but has code that's simply wrong at CostAnalysis.cs:309. Non-automatable goods are treated as if they cost 0 there, instead of the default Infinity. However, removing that special case creates incorrect "YAFC analysis: There are better recipes to create X. (Wasting 100% of YAFC cost)" messages for recipes with non-automatable goods.