Add separate variable for initial window size #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
reviewed
Jun 17, 2024
veger
force-pushed
the
make-window-size-testing-easy
branch
from
878489d to
8c549b2
Compare
|
Pushing the version with the rebase instead of the merge commit in the branch of @veger. Hopefully I won't break stuff. |
shpaass
force-pushed
the
make-window-size-testing-easy
branch
from
82e8214 to
75d306d
Compare
|
To clarify my message from some time ago, rebasing in the forks is fine. I prefer merge commits only when we merge pull requests into master. That allows a clean commit history when also keeping the chance of breaking the master branch low. |
shpaass
approved these changes
Jun 20, 2024
shpaass
added a commit
that referenced
this pull request
Jun 20, 2024
This time it's the PR #162 about the initial window size. It was merged right before this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing changed, but this makes it easier to test scrollbars, as the minimal window size can now be easily made very small.
With this we could also have different initial and minimal window sizes if/when desired.