forked from ShadowTheAge/yafc
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard and right-click shortcuts #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is awesome. Thank you for implementing this! I will check it out in 10 hours. |
veger
reviewed
Jun 13, 2024
Checked the basic functionality of Enter, Ctrl+T, and Right Mouse Button -- things work as expected. |
Also, we now have to tell each ImGui which InputSystem it should talk to.
DaleStan
force-pushed
the
add-shortcuts-35
branch
from
June 14, 2024 02:19
2bc495d
to
1f0cca9
Compare
shpaass
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for @veger to resolve the conversation.
veger
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #35 by adding the Enter/Return, right-click, and Ctrl+T behaviors mentioned there. It also adds right-click on products and ingredients to remove or create ordinary links (by asking "What can we clear when right-clicking on an ingredient?"), and right-click on desired products to remove and unlink them.
I'll admit I'm not a fan of 5676ce7, but I was unable to figure out how to get a single InputSystem to send Enter to the correct window when multiple OS windows were open.