Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw smaller icons over variable backgrounds. #144

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Jun 6, 2024

This adds a new preference (and alters the UI for an existing one) to allow you to choose how much to scale down certain icons:
image
The default is 90%, which is the middle size in this gif. The other two sizes shown are 80% and 100%; 100% shows the issue where the background color is not visible, hiding the link information.
Untitled

The Desired products, Summary ingredients, and Extra products icons all scale too.

Potential additions and/or reversions

The SelectMultiObjectPanel icons used to be fixed at 80%, but I chose to make them follow this setting too. The SelectSingleObjectPanel, icons were also fixed at 80%, but I just bumped them up to 100%, since they never have an interesting background. I can restore one or both SelectObjectPanel behaviors, or make SelectSingleObjectPanel follow this setting for consistency.
I can also extend the scaling to the recipe, entity, module, and/or beacon icons. I actually originally had the entity icon scale, but I saw how small the small assembler is (the crafter for Electrical engineering research 2) and decided I didn't want to make it even smaller.

@shpaass
Copy link
Owner

shpaass commented Jun 6, 2024

Just to clarify, you introduce this feature because you yourself use it, right? Not that I'm against it, just checking.
I would be against it if it was added when you did not use it yourself, because then we'd need to check if someone would use it at all.

@veger
Copy link
Collaborator

veger commented Jun 6, 2024

I would/will set the scale to 90% myself, as those colors convey (important) information and are sometimes impossible/hard to see.

@shpaass
Copy link
Owner

shpaass commented Jun 6, 2024

Ah, I see. The gif shows an example in Pysics Research Unboxing.

@shpaass shpaass merged commit 9edb974 into shpaass:master Jun 6, 2024
1 check passed
@DaleStan DaleStan deleted the draw-smaller-icons branch June 12, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants